Icon: Update Icons [GESTALT-8440] #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlingineni
changed the title
✅ Deploy Preview for gestalt ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Why are we reintroducing pincode? there were no usages in any platform. we were only using colored one. are we going to deprecate colored one? with all these new ones, are we going to remove all custom svgs? |
AlbertCarreras
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Instructions
Introducing new icons.
This also updates the icon component to swap the icon if
list-numberedis used because it needs a specific RTL iconDiff
Interactive differences in the PR are available to see here.
Classic Icons
VR Icons
New Icons Introduced
line-logo
wechat
viber
skype
snapchat
reddit
kakao-talk
telegram
pincode
indent
outdent
list-numbered
list-numbered-rtl
gift
Classic
VR
Links
Checklist